feat(QOV-1549): integrate port validation on helm chart#2354
Open
gdubroeucq wants to merge 1 commit intostagingfrom
Open
feat(QOV-1549): integrate port validation on helm chart#2354gdubroeucq wants to merge 1 commit intostagingfrom
gdubroeucq wants to merge 1 commit intostagingfrom
Conversation
Member
|
Qovery can create a Preview Environment for this PR.
This comment has been generated from Qovery AI 🤖.
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## staging #2354 +/- ##
===========================================
- Coverage 52.38% 47.94% -4.44%
===========================================
Files 381 153 -228
Lines 7949 3389 -4560
Branches 2432 1037 -1395
===========================================
- Hits 4164 1625 -2539
+ Misses 3008 1408 -1600
+ Partials 777 356 -421
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Issue:
It adds a basic check of every port created in a Helm chart.
Screenshots / Recordings
Before:

After:


(Without deploying the helm chart)
(After being deployed)
Testing
yarn testoryarn test -u(if you need to regenerate snapshots)yarn formatyarn lintPR Checklist
.cursor/rules)feat(service): add new Terraform service) - required for semantic-release